From 01199b63738fd26a5902531b13ed6031a6dbe4ef Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Thu, 19 Jun 2014 07:14:59 +0000 Subject: [PATCH] decode-dimms: Fix DDR3 extended temp range refresh rate decoding Based on a patch from Peter Missel. The meaning of byte 31, bit 1, was inverted. Also, this bit is only meaningful if the extended temperature range is supported (bit 0 is set.) git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@6249 7894878c-1315-0410-8ee3-d5d059ff63e0 --- CHANGES | 1 + eeprom/decode-dimms | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index 6ef1e3c..18ed8c4 100644 --- a/CHANGES +++ b/CHANGES @@ -36,6 +36,7 @@ SVN HEAD Don't print raw SSTE32882 register values Add support for Load Reduced DIMM (LRDIMM) DDR3 modules Fully decode the DDR3 SDRAM Device Type field + Fix DDR3 extended temp range refresh rate decoding Encode "degrees" to HTML degree symbol Generate XHTML 1.1 compliant markup Add a manual page diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms index b93f076..ca2e29f 100755 --- a/eeprom/decode-dimms +++ b/eeprom/decode-dimms @@ -1591,8 +1591,9 @@ sub decode_ddr3_sdram($) printl("DLL-Off Mode supported?", ($bytes->[30] & 128) ? "Yes" : "No"); printl("Operating temperature range", sprintf "0-%d degrees C", ($bytes->[31] & 1) ? 95 : 85); - printl("Refresh Rate in extended temp range", - ($bytes->[31] & 2) ? "2X" : "1X"); + printl_cond($bytes->[31] & 1, + "Refresh Rate in extended temp range", + ($bytes->[31] & 2) ? "1X" : "2X"); printl("Auto Self-Refresh?", ($bytes->[31] & 4) ? "Yes" : "No"); printl("On-Die Thermal Sensor readout?", ($bytes->[31] & 8) ? "Yes" : "No");