From 0eb91feeb7a1fbe955d4dd14ab093b353985310c Mon Sep 17 00:00:00 2001
From: Jean Delvare <jdelvare@suse.de>
Date: Thu, 11 Dec 2008 12:45:57 +0000
Subject: [PATCH] Do not decode DDR3 manufacturing data fields which have been
 left blank.

git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5552 7894878c-1315-0410-8ee3-d5d059ff63e0
---
 eeprom/decode-dimms | 41 ++++++++++++++++++++++++++---------------
 1 file changed, 26 insertions(+), 15 deletions(-)

diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
index 0c6676a..978edad 100755
--- a/eeprom/decode-dimms
+++ b/eeprom/decode-dimms
@@ -1289,27 +1289,36 @@ sub manufacture_date($$)
 sub decode_ddr3_mfg_data($)
 {
 	my $bytes = shift;
+	my ($l, $temp);
 
 	prints "Manufacturer Data";
 
 	printl "Module Manufacturer",
 		manufacturer_ddr3($bytes->[117], $bytes->[118]);
 
-	printl "DRAM Manufacturer",
-		manufacturer_ddr3($bytes->[148], $bytes->[149]);
+	if (spd_written(@{$bytes}[148..149])) {
+		printl "DRAM Manufacturer",
+			manufacturer_ddr3($bytes->[148], $bytes->[149]);
+	}
 
-	my $l = "Manufacturing Location";
-	my $temp = (chr($bytes->[119]) =~ m/^[\w\d]$/) ? chr($bytes->[119])
-	      : sprintf("0x%.2X", $bytes->[119]);
-	printl $l, $temp;
+	if (spd_written($bytes->[119])) {
+		$l = "Manufacturing Location Code";
+		my $temp = (chr($bytes->[119]) =~ m/^[\w\d]$/) ? chr($bytes->[119])
+		      : sprintf("0x%.2X", $bytes->[119]);
+		printl $l, $temp;
+	}
 
-	$l = "Manufacturing Date";
-	printl $l, manufacture_date($bytes->[120], $bytes->[121]);
+	if (spd_written(@{$bytes}[120..121])) {
+		$l = "Manufacturing Date";
+		printl $l, manufacture_date($bytes->[120], $bytes->[121]);
+	}
 
-	$l = "Assembly Serial Number";
-	$temp = sprintf("0x%02X%02X%02X%02X\n", $bytes->[122], $bytes->[123],
-		$bytes->[124], $bytes->[125]);
-	printl $l, $temp;
+	if (spd_written(@{$bytes}[122..125])) {
+		$l = "Assembly Serial Number";
+		$temp = sprintf("0x%02X%02X%02X%02X\n", $bytes->[122], $bytes->[123],
+			$bytes->[124], $bytes->[125]);
+		printl $l, $temp;
+	}
 
 	$l = "Part Number";
 	$temp = "";
@@ -1318,9 +1327,11 @@ sub decode_ddr3_mfg_data($)
 	};
 	printl $l, $temp;
 
-	$l = "Revision";
-	$temp = sprintf("0x%02X%02X\n", $bytes->[146], $bytes->[147]);
-	printl $l, $temp;
+	if (spd_written(@{$bytes}[146..147])) {
+		$l = "Revision Code";
+		$temp = sprintf("0x%02X%02X\n", $bytes->[146], $bytes->[147]);
+		printl $l, $temp;
+	}
 }
 
 # Parameter: EEPROM bytes 0-127 (using 64-98)