From 2e36fa9ff559bfc9a685ad758e618bd1c1f601f6 Mon Sep 17 00:00:00 2001
From: Jean Delvare <jdelvare@suse.de>
Date: Wed, 9 Jan 2019 15:00:55 +0100
Subject: [PATCH] decode-dimms: Print SPD revision for DDR3 too

Print the SPD revision of DDR3 modules as we do for all other
modules.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
 CHANGES             | 3 +++
 eeprom/decode-dimms | 6 +++++-
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/CHANGES b/CHANGES
index 104adf8..dcc6a38 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,9 @@
 i2c-tools CHANGES
 -----------------
 
+master
+  decode-dimms: Print SPD revision for DDR3 too
+
 4.1 (2018-11-30)
   Makefile: Make STRIP, DESTDIR and PREFIX overridable
   tools: Fix potential buffer overflows in i2cbusses
diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms
index e8835e3..eb92e6e 100755
--- a/eeprom/decode-dimms
+++ b/eeprom/decode-dimms
@@ -1551,7 +1551,7 @@ use constant DDR3_REGISTERED	=> 2;
 use constant DDR3_CLOCKED	=> 3;
 use constant DDR3_LOAD_REDUCED	=> 4;
 
-# Parameter: EEPROM bytes 0-127 (using 3-76)
+# Parameter: EEPROM bytes 0-127 (using 1-68)
 sub decode_ddr3_sdram($)
 {
 	my $bytes = shift;
@@ -1577,6 +1577,10 @@ sub decode_ddr3_sdram($)
 		{ type => "32b-SO-DIMM",	width => "67.6 mm",	family => DDR3_UNBUFFERED },
 	);
 
+# SPD revision
+	printl_cond($bytes->[1] != 0xff, "SPD Revision",
+		    ($bytes->[1] >> 4) . "." . ($bytes->[1] & 0xf));
+
 	printl("Module Type", ($bytes->[3] <= $#module_types) ?
 					$module_types[$bytes->[3]]->{type} :
 					sprintf("Reserved (0x%.2X)", $bytes->[3]));