From 4d476eb716c388d3c78e434b5e401e893067ab98 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Wed, 9 Jan 2019 15:00:59 +0100 Subject: [PATCH] decode-dimms: Move SDR-specific code SDR-specific code should go to its type-specific decoding function. Signed-off-by: Jean Delvare --- CHANGES | 1 + eeprom/decode-dimms | 12 ++++-------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/CHANGES b/CHANGES index dcc6a38..21362f0 100644 --- a/CHANGES +++ b/CHANGES @@ -3,6 +3,7 @@ i2c-tools CHANGES master decode-dimms: Print SPD revision for DDR3 too + Move SDR-specific code 4.1 (2018-11-30) Makefile: Make STRIP, DESTDIR and PREFIX overridable diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms index eb92e6e..9d80b75 100755 --- a/eeprom/decode-dimms +++ b/eeprom/decode-dimms @@ -741,7 +741,7 @@ sub sdram_module_configuration_type($) return join ", ", @edc; } -# Parameter: EEPROM bytes 0-127 (using 3-62) +# Parameter: EEPROM bytes 0-127 (using 3-62 and 126-127) sub decode_sdr_sdram($) { my $bytes = shift; @@ -1000,6 +1000,9 @@ sub decode_sdr_sdram($) $temp = (($bytes->[35] & 0x7f) >> 4) + ($bytes->[35] & 0xf) * 0.1; printl_cond(($bytes->[35] & 0xf) <= 9, "Data Signal Hold Time", (($bytes->[35] >> 7) ? -$temp : $temp) . " ns"); + +# Last 2 bytes (126-127) are reserved, Intel used them as an extension + decode_intel_spec_freq($bytes); } sub as_ddr($$) @@ -2693,13 +2696,6 @@ for $current (0 .. $#dimm) { # memory types) decode_manufacturing_information(\@bytes); } - -# Next 27 bytes (99-125) are manufacturer specific, can't decode - -# Last 2 bytes (126-127) are reserved, Intel used them as an extension - if ($type eq "SDR SDRAM") { - decode_intel_spec_freq(\@bytes); - } } # Side-by-side output format is only possible if all DIMMs have a similar