From 7c71a78fb03af1d91d55c6908299329c22825682 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Wed, 9 Jan 2019 15:01:02 +0100 Subject: [PATCH] Consistently use snprintf instead of sprintf There was a last instance of sprintf which somehow was not converted. I know it can't fail, but for consistency, let's use snprintf and check for truncation as we already do in gather_i2c_busses(). Signed-off-by: Jean Delvare --- tools/i2cbusses.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/tools/i2cbusses.c b/tools/i2cbusses.c index c0dbfb3..0002642 100644 --- a/tools/i2cbusses.c +++ b/tools/i2cbusses.c @@ -375,14 +375,21 @@ int parse_i2c_address(const char *address_arg) int open_i2c_dev(int i2cbus, char *filename, size_t size, int quiet) { - int file; + int file, len; - snprintf(filename, size, "/dev/i2c/%d", i2cbus); - filename[size - 1] = '\0'; + len = snprintf(filename, size, "/dev/i2c/%d", i2cbus); + if (len >= (int)size) { + fprintf(stderr, "%s: path truncated\n", filename); + return -EOVERFLOW; + } file = open(filename, O_RDWR); if (file < 0 && (errno == ENOENT || errno == ENOTDIR)) { - sprintf(filename, "/dev/i2c-%d", i2cbus); + len = snprintf(filename, size, "/dev/i2c-%d", i2cbus); + if (len >= (int)size) { + fprintf(stderr, "%s: path truncated\n", filename); + return -EOVERFLOW; + } file = open(filename, O_RDWR); }