From a03f0b4903257277ad0daea4c9a8a76bb3e2a160 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Thu, 20 Dec 2012 19:48:01 +0000 Subject: [PATCH] Add section headers for SDR modules, to make the output easier to read. git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@6100 7894878c-1315-0410-8ee3-d5d059ff63e0 --- CHANGES | 1 + eeprom/decode-dimms | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index da2df0c..8f3f84b 100644 --- a/CHANGES +++ b/CHANGES @@ -19,6 +19,7 @@ SVN HEAD Make DDR3 manufacturer count parity error non-fatal Strip former manufacturer name in side-by-side output mode Remove duplicate "ns" in SDR timings + Add section headers for SDR modules i2cdetect: Do a best effort detection if functionality is missing i2c-dev.h: Minimize differences with kernel flavor Move SMBus helper functions to include/i2c/smbus.h diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms index eafb17a..fbd2599 100755 --- a/eeprom/decode-dimms +++ b/eeprom/decode-dimms @@ -766,6 +766,7 @@ sub decode_sdr_sdram($) printl_cond(defined $cycle_time, "Cycle Time", $cycle_time); printl_cond(defined $access_time, "Access Time", $access_time); + prints("Attributes"); $temp = ""; if ($bytes->[21] & 1) { $temp .= "Buffered Address/Control Inputs\n"; } if ($bytes->[21] & 2) { $temp .= "Registered Address/Control Inputs\n"; } @@ -775,8 +776,7 @@ sub decode_sdr_sdram($) if ($bytes->[21] & 32) { $temp .= "Differential Clock Input\n"; } if ($bytes->[21] & 64) { $temp .= "Redundant Row Address\n"; } if ($bytes->[21] & 128) { $temp .= "Undefined (bit 7)\n"; } - if ($bytes->[21] == 0) { $temp .= "(None Reported)\n"; } - printl("SDRAM Module Attributes", $temp); + printl_cond($bytes->[21], "SDRAM Module Attributes", $temp); $temp = ""; if ($bytes->[22] & 1) { $temp .= "Supports Early RAS# Recharge\n"; } @@ -791,6 +791,7 @@ sub decode_sdr_sdram($) if ($bytes->[22] & 128) { $temp .= "Undefined (bit 7)\n"; } printl("SDRAM Device Attributes (General)", $temp); + prints("Timing Parameters"); printl("Minimum Row Precharge Time", value_or_undefined($bytes->[27], "ns"));