From a1813bf8c84cd617e50de8a68a69e8c9cd5201d1 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Thu, 11 Dec 2008 16:23:46 +0000 Subject: [PATCH] Fix obvious decoding logic bug in decode_sdr_sdram(). git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5560 7894878c-1315-0410-8ee3-d5d059ff63e0 --- eeprom/decode-dimms | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms index e9bf29f..97eb0f6 100755 --- a/eeprom/decode-dimms +++ b/eeprom/decode-dimms @@ -523,7 +523,7 @@ sub decode_sdr_sdram($) else { $temp = "Undefined!"; } printl("Module Configuration Type", $temp); - if ($bytes->[12] > 126) { $temp = "Self Refreshing"; } + if ($bytes->[12] & 0x80) { $temp = "Self Refreshing"; } else { $temp = "Not Self Refreshing"; } printl("Refresh Type", $temp); @@ -537,13 +537,13 @@ sub decode_sdr_sdram($) else { $temp = "Undefined!"; } printl("Refresh Rate", $temp); - if ($bytes->[13] > 126) { $temp = "Bank2 = 2 x Bank1"; } + if ($bytes->[13] & 0x80) { $temp = "Bank2 = 2 x Bank1"; } else { $temp = "No Bank2 OR Bank2 = Bank1 width"; } printl("Primary SDRAM Component Bank Config", $temp); printl("Primary SDRAM Component Widths", value_or_undefined($bytes->[13] & 0x7f)); - if ($bytes->[14] > 126) { $temp = "Bank2 = 2 x Bank1"; } + if ($bytes->[14] & 0x80) { $temp = "Bank2 = 2 x Bank1"; } else { $temp = "No Bank2 OR Bank2 = Bank1 width"; } printl("Error Checking SDRAM Component Bank Config", $temp); printl("Error Checking SDRAM Component Widths",