From b9cf0129a9d9f40e081c975975b8a71188ca7ba6 Mon Sep 17 00:00:00 2001 From: Jean Delvare Date: Thu, 23 Jun 2016 16:29:54 +0200 Subject: [PATCH] decode-dimms: Fix DDR3 extended temp range refresh rate decoding Based on a patch from Peter Missel. The meaning of byte 31, bit 1, was inverted. Also, this bit is only meaningful if the extended temperature range is supported (bit 0 is set.) --- CHANGES | 3 +++ eeprom/decode-dimms | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CHANGES b/CHANGES index 35cdaa3..662e8c3 100644 --- a/CHANGES +++ b/CHANGES @@ -1,6 +1,9 @@ i2c-tools CHANGES ----------------- +3.1.2 (work in progress) + decode-dimms: Fix DDR3 extended temp range refresh rate decoding + 3.1.1 "Happy Birthday Pollux" (2014-02-20) decode-dimms: Decode module configuration type of DDR2 SDRAM Decode bus width extension of DDR3 SDRAM diff --git a/eeprom/decode-dimms b/eeprom/decode-dimms index 60b95c0..a088ba0 100755 --- a/eeprom/decode-dimms +++ b/eeprom/decode-dimms @@ -1289,8 +1289,9 @@ sub decode_ddr3_sdram($) printl("DLL-Off Mode supported?", ($bytes->[30] & 128) ? "Yes" : "No"); printl("Operating temperature range", sprintf "0-%d degrees C", ($bytes->[31] & 1) ? 95 : 85); - printl("Refresh Rate in extended temp range", - ($bytes->[31] & 2) ? "2X" : "1X"); + printl_cond($bytes->[31] & 1, + "Refresh Rate in extended temp range", + ($bytes->[31] & 2) ? "1X" : "2X"); printl("Auto Self-Refresh?", ($bytes->[31] & 4) ? "Yes" : "No"); printl("On-Die Thermal Sensor readout?", ($bytes->[31] & 8) ? "Yes" : "No");