Jean Delvare
96fca5cdb0
tools: Don't build with -Winline
The inlining issues are never going to be fixed in this branch, so
there is no point in flooding the build with these warnings.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
5 years ago
Jean Delvare
11a1738e83
i2cset: Fix short writes with mask
Short writes used "daddress" for the value, but the masking code did
not expect that, and instead applied the mask to a variable that was
never used.
So change short writes to use "value" for the value, as all other
commands do. Adjust all code paths accordingly.
Reported by David Jedynak.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
5 years ago
Jean Delvare
a5a59fb959
tools: i2cbusses: Check the return value of snprintf
It's very unlikely that these paths will ever be truncated, but
better safe than sorry.
Suggested by Uwe Kleine-König.
8 years ago
Jean Delvare
7c71a78fb0
Consistently use snprintf instead of sprintf
There was a last instance of sprintf which somehow was not converted.
I know it can't fail, but for consistency, let's use snprintf and
check for truncation as we already do in gather_i2c_busses().
Signed-off-by: Jean Delvare <jdelvare@suse.de>
7 years ago
Jean Delvare
07563e8ff8
i2c-tools: i2cbusses: Avoid buffer overflows in sysfs paths
sprintf isn't safe, use snprintf instead.
8 years ago
Jean Delvare
3b194ddb8c
Delete i2ctransfer
A maintenance branch isn't the right place for a brand new tool. Now
that i2c tools version 4.0 has been released, there's no reason to
keep i2ctransfer in the 3.1 branch, so delete it.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Wolfram Sang <wsa@the-dreams.de>
8 years ago
Jean Delvare
ba2abe60bd
Add missing man page cross-references
8 years ago
Wolfram Sang
c1ea203e35
i2c-tools: add new tool 'i2ctransfer'
This tool allows to construct and concat multiple I2C messages into one
single transfer. Its aim is to test I2C master controllers, and so there
is no SMBus fallback.
I've been missing such a tool a number of times now, so I finally got
around to writing it myself. As with all I2C tools, it can be dangerous,
but it can also be very useful when developing.
It has been tested with various Renesas I2C IP cores as well as Tegra,
i.MX and AT91.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
11 years ago
Wolfram Sang
58ebb2f385
i2c-tools: add .gitignore
Don't display generated files, so 'git status' becomes useful again.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
9 years ago
Wolfram Sang
119a811034
i2c-tools: fix feature test macros for glibc >= 2.20
Since glibc 2.20, the usage of _BSD_SOURCE is deprecated. Fix it like
described here:
https://sourceware.org/glibc/wiki/Release/2.20#Deprecation_of__BSD_SOURCE_and__SVID_SOURCE_feature_macros
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
9 years ago
Jean Delvare
a0d9fb99f8
i2c-dev: Revert most of r6048 and r6052
I don't know what I had in mind but commits r6048:
i2c-dev: Move SMBus helper functions to include/i2c/smbus.h
and r6052:
Add header file missed from a previous commit
were way too intrusive for a maintenance branch. Revert most of
them, only keeping the legitimate include fixes.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/branches/i2c-tools-3.1@6228 7894878c-1315-0410-8ee3-d5d059ff63e0
12 years ago
Jean Delvare
2df6dcb997
Update my e-mail address and copyright years.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/branches/i2c-tools-3.1@6225 7894878c-1315-0410-8ee3-d5d059ff63e0
12 years ago
Jean Delvare
ba1491d03d
Add missing option -r to usage summary
Reported by Jaromir Capik.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/branches/i2c-tools-3.1@6202 7894878c-1315-0410-8ee3-d5d059ff63e0
12 years ago
Jean Delvare
e1974d0945
i2cdetect: Clarify the SMBus commands used for probing by default.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/branches/i2c-tools-3.1@6110 7894878c-1315-0410-8ee3-d5d059ff63e0
13 years ago
Jean Delvare
0a335f0859
Tools depends on header file version.h. Add the missing dependency to
the build system.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@6049 7894878c-1315-0410-8ee3-d5d059ff63e0
13 years ago
Jean Delvare
93caf007f4
i2c-dev: Move SMBus helper functions to include/i2c/smbus.h
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@6048 7894878c-1315-0410-8ee3-d5d059ff63e0
13 years ago
Guenter Roeck
055f5effa9
i2cset: Check range for data value mask
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5927 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Guenter Roeck
6fdf1f1e45
i2cset: Get command/mode before reading data
Get and validate the command/mode parameter for all commands
before reading and evaluating actual data.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5926 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Guenter Roeck
8da93bb0f2
i2cset: More stringent parameter validation
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5924 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Guenter Roeck
7b4639c497
i2cset: Abort if value mask is set for block commands
Specifying the value mask is not supported for block commands,
abort if it is specified anyway.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5923 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Guenter Roeck
bacad27586
i2cset: Check number of arguments for block data writes
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5922 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Guenter Roeck
7dd2610269
i2cset: Removed obsolete method to specify value mask
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5921 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Guenter Roeck
37ad9258ab
i2cset: Replace blanks at beginning of line with tabs
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5920 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Guenter Roeck
fcc8ce36b8
Added support to write SMBus and I2C block commands to i2cset
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5911 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Jean Delvare
3a5d21649e
Use a 20-bit limit for the i2c bus number.
Use snprintf for the i2c dev node name.
Update copyright years.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5885 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Jean Delvare
54a2dcbba5
tools: Drop arbitrary limit on I2C bus number
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5884 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Jean Delvare
7e6f85bfc5
Drop legacy reference to ISA bus. The i2c-isa fake bus driver is gone
long ago, today the message is only confusing.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5862 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Jean Delvare
e8c558c9a5
Properly handle the rare case where /dev/i2c exists but isn't a
directory. Patch from Florian Fainelli.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5854 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
Jean Delvare
2ea4dccae0
Add support for short writes with PEC.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5771 7894878c-1315-0410-8ee3-d5d059ff63e0
16 years ago
Jean Delvare
f0892fadae
List include first, so that other modules can use it.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5610 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
52cb1789b4
Complete GPL header.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5596 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
24f819ed0c
Licensing clarification.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5594 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
0d84adf510
Add missing includes.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5452 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
0e972ad9fd
Add support for reading back to short writes.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5394 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
35a929de32
Make reading back the written value optional.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5393 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
f9bad5666d
Clarify the requirements of data value masking.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5392 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
0c270e09de
Allow masking on short writes.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5391 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
c797cbaaeb
Set the data value mask with -m. The old method is still supported for
compatibility, but is considered deprecated and is no longer documented.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5390 7894878c-1315-0410-8ee3-d5d059ff63e0
17 years ago
Jean Delvare
54cee12770
Use consistent transaction names (based on the SMBus specification)
when complaining about a missing adapter functionality.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5242 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
fc38f35ce4
Share the error string between all functionality checks.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5241 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
f67174055a
No need to print the i2c bus number in functionality error message.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5240 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
9160a95ad0
Split the functionality checking code into a separate function for
clarity.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5239 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
cc723a46f7
Close device file before we exit.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5238 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
c3d335575f
Add support for short writes (SMBus send byte).
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5237 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
7ad89259ab
List the optional command line parameters in a consistent way.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5236 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
8cc44b8c9c
Whitespace cleanups.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5210 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
8603e2aab2
Move the confirmation to a separate function, as is done in i2cget
already.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5209 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
87154f13cc
Move the functionality checks to a separate function, as is done in
i2cget already.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5208 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
68fb2e6229
Minor optimizations and cleanups.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5207 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
2751626db8
Unknown options are fatal, so label them error rather than warning.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5206 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago