230be0e72f
i2cdump: Remove dead code
Considering that we exit immediately if an error happens during a
block read, the code filling the remaining bytes with -1 (so that
they will be displayed as "XX") is effectively dead code, so let's
remove it.
We might want to revisit the whole logic later, as there's in fact
little reason why block read errors would be fatal when all other
read errors are not. But I'd rather remove SMBus block support from
the tool before attempting to clean up the code.
Fixes: 7abc52d779
4 years ago
78edfefbcc
tools: restrict all addresses defined by the standard
The I2C standard reserves addresses 0x03-0x07. Adapt our tools to that.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Acked-by: Jean Delvare <jdelvare@suse.de>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
6 years ago
702804251c
tools: add all_addrs option for i2c tools
If the user is sure that the reserved 0x00 - 0x02 and 0x77 - 0x7f ranges
are not needed by its devices, then the "-a" option can be passed for
allowing all theorical addresses to be used. It is then possible to
access devices in this address range.
Signed-off-by: Romain Porte <romain.porte@nokia.com>
Reviewed-by: Peter Rosin <peda@axentia.se>
[wsa: imonr fixes to commit message]
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
8 years ago
4bbad0fae1
Update my e-mail address and copyright years.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@6224 7894878c-1315-0410-8ee3-d5d059ff63e0
12 years ago
93caf007f4
i2c-dev: Move SMBus helper functions to include/i2c/smbus.h
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@6048 7894878c-1315-0410-8ee3-d5d059ff63e0
13 years ago
3a5d21649e
Use a 20-bit limit for the i2c bus number.
Use snprintf for the i2c dev node name.
Update copyright years.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5885 7894878c-1315-0410-8ee3-d5d059ff63e0
15 years ago
54cee12770
Use consistent transaction names (based on the SMBus specification)
when complaining about a missing adapter functionality.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5242 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
fc38f35ce4
Share the error string between all functionality checks.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5241 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
f67174055a
No need to print the i2c bus number in functionality error message.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5240 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
9160a95ad0
Split the functionality checking code into a separate function for
clarity.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5239 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
7ad89259ab
List the optional command line parameters in a consistent way.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5236 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
8cc44b8c9c
Whitespace cleanups.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5210 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
2751626db8
Unknown options are fatal, so label them error rather than warning.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5206 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
bdfc87d724
Move the chip address parsing to a common function for consistency.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5204 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
2e942d16a5
Consistently restrict the allowed I2C device address to 0x03 - 0x77.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5203 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
2c57ef91a2
Unify and shorten the usage messages. The details can be found in
the man pages so no need to be verbose.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5201 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
b68190b426
Don't print the list of i2c buses as part of the help.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5200 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
adc03e3cf3
Make the includes order correct and consistent accross all tools.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5199 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
eda5918d0f
Refactor the handling of the I2CBUS parameter. This ensures more
consistency accross the i2c tools.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5193 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
aed7163f2b
Update the FSF address.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5164 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
8e4ddd1f56
Let the user specify a register range.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5151 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
7abc52d779
Return the correct error code on I2C block read failure.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@5073 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
fcb6bce3c8
Rename I2C_FUNC_SMBUS_HWPEC_CALC to I2C_FUNC_SMBUS_PEC, as was done
in the Linux 2.6 kernel.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@4948 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
7457b172b0
Show more warnings, and fix them.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@4499 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
a738f64223
Remove remaining references to lm-sensors.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@4488 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
0edf1c69c9
Add a Makefile to build, install and uninstall the tools, and make
them build again.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@4487 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
c922a78bb4
Oops, forgot to create the trunk level.
git-svn-id: http://lm-sensors.org/svn/i2c-tools/trunk@4481 7894878c-1315-0410-8ee3-d5d059ff63e0
18 years ago
Jean Delvare
Wolfram Sang
Romain Porte